Skip to content

Conversation

@WojciechMazur
Copy link
Contributor

  • Added task to validate that produced .jar, -sources.jar, -javadoc.jar are effectively empty (contain only META-INF, no .class, .tasty, .sjsir .html, etc)
  • Don't delegate scala3-library-bootstrapepd and scala3-library-sjs for doc tasks to scala-library-bootstrapped tasks - Fixes scala3-library javadoc contains duplicated scala-library documentation #24807
  • Also don't delegate scala3-library-nonboostrapped
  • Deduplicate settings used in all of the mentioned tasks

Piggy backed changes (small improvements unrelated directlly to the core of the PR):

  • simplifiy fetchedScalaInstanceSettings - always use scalaVersion.value
  • ensure that downloaded sbt-scala3-bridge uses the same version as used scalaVersion

@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Dec 22, 2025
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Dec 22, 2025
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WojciechMazur WojciechMazur merged commit 4120987 into scala:main Dec 22, 2025
54 checks passed
@WojciechMazur WojciechMazur deleted the build/scala3-library-empty-javadocs branch December 22, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scala3-library javadoc contains duplicated scala-library documentation

2 participants